Skip to content

Conversation

@jean-lucas
Copy link
Contributor

In Dataset.create_slice, the reference_ids parameter is now optional. If left unspecified, it will create an empty slice

@jean-lucas jean-lucas requested a review from gatli February 28, 2024 16:15
Copy link
Contributor

@gatli gatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the CHANGELOG shade 😆

CHANGELOG.md Outdated
Comment on lines 14 to 18
## [0.17.1](https://github.com/scaleapi/nucleus-python-client/releases/tag/v0.17.1) - 2024-02-14

No major changes


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - I added a changelog in https://github.com/scaleapi/nucleus-python-client/pull/431/files

## [0.17.1] - 2024-02-22

### Added
- Environment variable `NUCLEUS_SKIP_SSL_VERIFY` to skip SSL verification on requests

@jean-lucas jean-lucas merged commit db9d5f2 into master Feb 29, 2024
@jean-lucas jean-lucas deleted the jean-lucas-allow-empty-slices branch February 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants