Shield against breaking changes from scikit-learn 1.3.0 release#598
Open
exs-avianello wants to merge 2 commits intoscikit-learn-contrib:masterfrom
Open
Shield against breaking changes from scikit-learn 1.3.0 release#598exs-avianello wants to merge 2 commits intoscikit-learn-contrib:masterfrom
exs-avianello wants to merge 2 commits intoscikit-learn-contrib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a possible fix for #597 - following the approach mentioned in scikit-learn/scikit-learn#26742
It replaces all references to the
KDTreeandBallTree.valid_metricsattribute (which is not available anymore sincescikit-learn==1.3.0) with calls to the new equivalent.valid_metrics()method:As suggested in #597, another completely valid approach would be to hard-code the lists of acceptable metric names instead 🙌
Note that the following metrics are not available anymore in
BallTree.valid_metrics():['wminkowski', 'matching', 'kulsinski']