Refactor data flow #204
Merged
Refactor data flow #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create ArrayBox with 3 separately-interfaced properties: accessible, mutable, observable. - Pass ArrayBox of MatchTerms into toolbar to allow modification - Observe ArrayBox of MatchTerms in content to respond to changes - Create TermsSyncService to observe ArrayBox of MatchTerms, sending them to background automatically if they become out of sync
- Hand responsibility of content for updating the toolbar when terms mutate to the toolbar itself
- Major refactoring work revisiting a lot of old decisions, particularly relating to data flow and messages between (and within) background and content - Modularise more functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.