ci: tidy up workflows and implement a consistent style #1905

sudo-kraken · 2025-09-15T15:14:50Z

feat(ci): tidy up workflows and implement a consistent style

all workflows now use ubuntu-24.04 as the runner type to match the release workflows

codeql.yml

bump actions to v3
add least-privilege perms + concurrency to stop duplicate runs
ignore docs only changes

conflict_labeler.yml

run on opened, reopened, and synchronize
bump action version
add concurrency group to avoid duplicate labeling

cypress.yml

skip docs-only changes; don’t run on draft PRs
add concurrency to stop duplicate runs + 10m timeout

docs-deploy.yml

add configure-pages@v5 and bump upload-pages-artifact to v4
set explicit pages/id-token perms + concurrency
minor cleanups (working-directory, ubuntu-24.04)

helm.yml

switch oras discover to oras manifest fetch
add concurrency to stop duplicate runs

lint-helm-charts.yml

bump action versions
enforce version bumps (--check-version-increment=true)
add least-privilege perms + concurrency to stop duplicate runs

support.yml

add least-privilege perms

test-docs-deploy.yml

add least-privilege perms + concurrency to stop duplicate runs

all workflows now use ubuntu-24.04 as the runner type to match the release workflows codeql.yml - bump actions to v3 - add least-privilege perms + concurrency to stop duplicate runs - ignore docs only changes conflict_labeler.yml - run on opened, reopened, and synchronize - bump action version - add concurrency group to avoid duplicate labeling cypress.yml - skip docs-only changes; don’t run on draft PRs - add concurrency to stop duplicate runs + 10m timeout docs-deploy.yml - add configure-pages@v5 and bump upload-pages-artifact to v4 - set explicit pages/id-token perms + concurrency - minor cleanups (working-directory, ubuntu-24.04) helm.yml - switch oras discover to oras manifest fetch - add concurrency to stop duplicate runs lint-helm-charts.yml - bump action versions - enforce version bumps (--check-version-increment=true) - add least-privilege perms + concurrency to stop duplicate runs support.yml - add least-privilege perms test-docs-deploy.yml - add least-privilege perms + concurrency to stop duplicate runs

gauthier-th · 2025-09-15T15:22:43Z

CC: @M0NsTeRRR

.github/workflows/docs-deploy.yml

.github/workflows/lint-helm-charts.yml

.github/workflows/docs-deploy.yml

.github/workflows/codeql.yml

sudo-kraken · 2025-09-22T13:43:18Z

@M0NsTeRRR I just pushed the commit, please let me know when you have looked over it.

M0NsTeRRR

Have you run zizmor also ?

.github/workflows/codeql.yml

.github/workflows/conflict_labeler.yml

.github/workflows/docs-deploy.yml

sudo-kraken · 2025-09-23T11:01:44Z

@M0NsTeRRR this is where we will see some issues now as we made this two separate PR's I added the pnpm logic into these workflows but these will now fail the tests as the package.json changes are not present in this PR.

sudo-kraken · 2025-09-23T11:29:07Z

Closed PR-1904 and merged into PR-1905.

fallenbagel

@sudo-kraken lockfile needs to be updated

github-actions · 2025-09-23T11:55:30Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

sudo-kraken · 2025-09-23T11:56:51Z

@sudo-kraken lockfile needs to be updated

dfbfd63

gauthier-th · 2025-09-23T12:07:03Z

@sudo-kraken there is still a merge conflict in the lock file

sudo-kraken · 2025-09-23T12:37:49Z

The conflict is resolved and tests passed.

sudo-kraken · 2025-09-23T13:12:15Z

I have created a branch with the updated workflows in my fork then pr'd them into develop to test along with the updated Dockerfile and package.json etc, with the only difference being that the publishing sections are removed leaving only the builds in, the preview run has been successful and the other is running see below:

Preview: https://github.com/sudo-kraken/jellyseerr/actions/runs/17947025757
CI: https://github.com/sudo-kraken/jellyseerr/actions/runs/17947180858

sudo-kraken · 2025-09-23T13:23:49Z

Last hotfix hopefully, added to update the latest tag in release.yml as it was still using the old env var for the owner.

.github/workflows/ci.yml

.github/workflows/preview.yml

.github/workflows/ci.yml

.github/workflows/codeql.yml

.github/workflows/cypress.yml

.github/workflows/docs-deploy.yml

.github/workflows/helm.yml

.github/workflows/preview.yml

Dockerfile

…u actions

gauthier-th

LGTM

.github/workflows/cypress.yml

Signed-off-by: Ludovic Ortega <[email protected]>

M0NsTeRRR · 2025-09-23T20:58:18Z

Fixed :

Some typos
Enabled CodeQL on github actions
Removed hardcoded repository reference
Removed unused snap workflow
Refactored ci and support workflow to avoid useless third party github action
Force singleQuote configuration in vscode settings (I don't have prettier installed)

Otherwise LGTM, @sudo-kraken any comment on my last commit ?

Signed-off-by: Ludovic Ortega <[email protected]>

sudo-kraken · 2025-09-24T03:50:02Z

Fixed :

Some typos

Enabled CodeQL on github actions

Removed hardcoded repository reference

Removed unused snap workflow

Refactored ci and support workflow to avoid useless third party github action

Force singleQuote configuration in vscode settings (I don't have prettier installed)

Otherwise LGTM, @sudo-kraken any comment on my last commit ?

Review complete, all good from me, good work. LGTM 👍

github-advanced-security · 2025-09-24T03:52:28Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/ci.yml

-        uses: docker/build-push-action@v5
+
+      - name: Warm cache (no push) — ${{ matrix.platform }}
+        uses: docker/build-push-action@v6


.github/workflows/ci.yml

+        run: echo "TIMESTAMP=$(git log -1 --pretty=%ct)" >> "$GITHUB_OUTPUT"
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3


.github/workflows/ci.yml

-          docker manifest push ghcr.io/${{ env.OWNER_LC }}/jellyseerr:develop
+      - name: Extract metadata
+        id: meta
+        uses: docker/metadata-action@v5


.github/workflows/ci.yml

+            org.opencontainers.image.created=${{ steps.ts.outputs.TIMESTAMP }}
+
+      - name: Build & Push (multi-arch, single tag)
+        uses: docker/build-push-action@v6


.github/workflows/lint-helm-charts.yml

+
      - name: Set up Helm
-        uses: azure/[email protected]
+        uses: azure/setup-helm@v4


.github/workflows/release.yml

+        run: echo "TIMESTAMP=$(git log -1 --pretty=%ct)" >> "$GITHUB_OUTPUT"
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3


.github/workflows/release.yml

+        uses: docker/setup-buildx-action@v3
+
+      - name: Log in to Docker Hub
+        uses: docker/login-action@v3


.github/workflows/release.yml

+          password: ${{ secrets.DOCKER_TOKEN }}
+
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v3


.github/workflows/release.yml

+
+      - name: Extract metadata
+        id: meta
+        uses: docker/metadata-action@v5


.github/workflows/release.yml

+            org.opencontainers.image.created=${{ steps.ts.outputs.TIMESTAMP }}
+
+      - name: Build & Push (multi-arch, single tag)
+        uses: docker/build-push-action@v6


.vscode/settings.json

fallenbagel · 2025-09-25T05:13:50Z

@all-contributors please add @sudo-kraken for infra

allcontributors · 2025-09-25T05:13:59Z

@fallenbagel

I've put up a pull request to add @sudo-kraken! 🎉

sudo-kraken requested review from fallenbagel and gauthier-th as code owners September 15, 2025 15:14

gauthier-th changed the title ~~Feat update remaining workflows~~ ci: update workflows architecture Sep 15, 2025

gauthier-th changed the title ~~ci: update workflows architecture~~ ci: tidy up workflows and implement a consistent style Sep 15, 2025

fixed line 5 syntax error

787df87

M0NsTeRRR reviewed Sep 21, 2025

View reviewed changes

.github/workflows/docs-deploy.yml Outdated Show resolved Hide resolved

.github/workflows/lint-helm-charts.yml Outdated Show resolved Hide resolved

.github/workflows/lint-helm-charts.yml Outdated Show resolved Hide resolved

.github/workflows/docs-deploy.yml Outdated Show resolved Hide resolved

M0NsTeRRR reviewed Sep 21, 2025

View reviewed changes

.github/workflows/codeql.yml Show resolved Hide resolved

M0NsTeRRR mentioned this pull request Sep 21, 2025

ci: native ARM builds + updated workflow architecture #1904

Closed

Updated based on comments from @M0NsTeRRR in PR-1905 discussion

8de2175

M0NsTeRRR reviewed Sep 22, 2025

View reviewed changes

.github/workflows/codeql.yml Show resolved Hide resolved

.github/workflows/conflict_labeler.yml Show resolved Hide resolved

.github/workflows/docs-deploy.yml Outdated Show resolved Hide resolved

.github/workflows/docs-deploy.yml Outdated Show resolved Hide resolved

updated based on 2nd review from @M0NsTeRRR in PR-1905

a1405ad

Merge of PR-1904 and PR-1905

056e6f5

fallenbagel reviewed Sep 23, 2025

View reviewed changes

chore(pnpm-lock.yaml): updated the pnpm-lockfile

dfbfd63

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Sep 23, 2025

chore(pnpm-lock.yml): refresh lockfile after merging develop

efb0a11

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Sep 23, 2025

ci(release.yml): fix the latest tag to use context labels

ed4c004

gauthier-th requested changes Sep 23, 2025

View reviewed changes

ci: fix new lines at eof, removed cypress timeout, removed legacy qem…

4e9d2a4

…u actions

gauthier-th previously approved these changes Sep 23, 2025

View reviewed changes

fallenbagel requested changes Sep 23, 2025

View reviewed changes

.github/workflows/cypress.yml Outdated Show resolved Hide resolved

@M0NsTeRRR self review

f55e424

Signed-off-by: Ludovic Ortega <[email protected]>

M0NsTeRRR dismissed gauthier-th’s stale review via f55e424 September 23, 2025 20:54

fix: support workflow

9d4424e

Signed-off-by: Ludovic Ortega <[email protected]>

github-advanced-security bot found potential problems Sep 24, 2025

View reviewed changes

fallenbagel previously approved these changes Sep 24, 2025

View reviewed changes

fallenbagel requested a review from gauthier-th September 24, 2025 05:11

gauthier-th requested changes Sep 24, 2025

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

fix: newline

db0a306

M0NsTeRRR dismissed fallenbagel’s stale review via db0a306 September 24, 2025 12:04

gauthier-th approved these changes Sep 24, 2025

View reviewed changes

fallenbagel merged commit f46a763 into seerr-team:develop Sep 25, 2025
10 checks passed

allcontributors bot mentioned this pull request Sep 25, 2025

docs: add sudo-kraken as a contributor for infra #1919

Merged

sudo-kraken deleted the feat-update-workflows branch September 25, 2025 07:17

fallenbagel mentioned this pull request Sep 28, 2025

commitTag of $GIT_SHA in /api/v1/status for Docker image #707

Closed

1 task

Uh oh!

ci: tidy up workflows and implement a consistent style #1905

ci: tidy up workflows and implement a consistent style #1905

Uh oh!

Conversation

sudo-kraken commented Sep 15, 2025

Uh oh!

gauthier-th commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sudo-kraken commented Sep 22, 2025

Uh oh!

M0NsTeRRR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

fallenbagel left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

gauthier-th commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gauthier-th left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

M0NsTeRRR commented Sep 23, 2025

Uh oh!

sudo-kraken commented Sep 24, 2025

Uh oh!

github-advanced-security bot commented Sep 24, 2025

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!