Merged
Conversation
One of our tests currently checks resubmitting a create op after reconnecting during submission. However, since reconnection happens so quickly, this test case can cause two commit attempts in parallel. We currently only wait for the first request to resolve, which means that the second request can continue into the next test, causing unexpected test failures. This change waits for both acks to be sent before finishing the test.
Collaborator
Author
|
This is an example error of the failing test: |
ericyhwang
approved these changes
Jun 11, 2024
Contributor
ericyhwang
left a comment
There was a problem hiding this comment.
Per discussion, we should separately consider doing a db.close() in sharedb-mongo afterEach for these test cases imported from core, as that may help with these kinds of issues in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our tests currently checks resubmitting a create op after reconnecting during submission.
However, since reconnection happens so quickly, this test case can cause two commit attempts in parallel.
We currently only wait for the first request to resolve, which means that the second request can continue into the next test, causing unexpected test failures.
This change waits for both acks to be sent before finishing the test.