Gemini Integration #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have fixed the necessary conflicts you can now approve merge on the develop branch. Thanks! |
shure-dev
requested changes
Aug 30, 2024
extractor.py
Outdated
logllm/log_llm.py
Outdated
|
|
||
| def init_wandb(project_name): | ||
| wandb.init(project=project_name, settings=wandb.Settings(_disable_stats=True)) | ||
|
|
||
| def extract_experimental_conditions(code): | ||
| def extract_experimental_conditions_gemini(code): |
There was a problem hiding this comment.
I think you do not have to make two functions, you can have one function where you use if branch to switch openai and gemini
Comment on lines
-24
to
-37
| {{ | ||
| "method":"str", | ||
| "dataset":"str", | ||
| "task":"str", | ||
| "accuracy":"", | ||
| "other_param_here":{ | ||
| "other_param_here":"", | ||
| "other_param_here":"", | ||
| }, | ||
| "other_param_here":"", | ||
| ... | ||
| "condition_as_natural_langauge":["Small dataset."], | ||
| "advice_to_improve_acc":["Use bigger dataset.","Use more simple model."] | ||
| }} |
There was a problem hiding this comment.
Yes please check on the suggestions I made on the issues post.
logllm/query.py
Outdated
There was a problem hiding this comment.
This is an implementing feature, we can ignore for now.
There was a problem hiding this comment.
You should at least make it more clear what role intended for that query function on the logllm.
setup.py
Outdated
There was a problem hiding this comment.
you may not need to change this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the generative model to Gemini
Changed the
setupconfigurationChanged the
test_loggercompatible to the gemini modelAdjusted the
query.pyfile for gemini model