docs: improve doc for --no-upload option #4206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
- Coverage 40.10% 34.39% -5.72%
==========================================
Files 155 211 +56
Lines 10044 14062 +4018
==========================================
+ Hits 4028 4836 +808
- Misses 5530 8613 +3083
- Partials 486 613 +127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change adds documentation to the `no-upload` option of the `cosign attest` command to clarify that when the option is used, the produced attestation is written to STDOUT Signed-off-by: Travis Truman <[email protected]>
haydentherapper
approved these changes
Jun 10, 2025
Contributor
|
Sorry for taking awhile to review. Can you rebase against main, that'll pick up a fix for the failing test? |
haydentherapper
approved these changes
Jun 16, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 18, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cosign](https://github.com/sigstore/cosign) | patch | `2.5.1` -> `2.5.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sigstore/cosign (cosign)</summary> ### [`v2.5.2`](https://github.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v252) [Compare Source](sigstore/cosign@v2.5.1...v2.5.2) #### Bug Fixes - Do not load trusted root when CT env key is set #### Documentation - docs: improve doc for --no-upload option ([#​4206](sigstore/cosign#4206)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41OS4zIiwidXBkYXRlZEluVmVyIjoiNDAuNTkuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds additional documentation to the
no-uploadoption of thecosign attestcommand to clarify that when the option is used, the produced attestation is written to STDOUTCloses #4163
Release Note
NONE
Documentation