Repository navigation
Allow guzzlehttp/psr7 3 - #102
Open
sinemacula-ben wants to merge 1 commit into
Open
sinemacula-ben wants to merge 1 commit into
sinemacula-ben wants to merge 1 commit into
Conversation
This was referenced Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guzzle 8 requires
guzzlehttp/psr73. The 2.x line pins psr7 to~2.8, so any application on saml2 v6 is held on Guzzle 7, and an application already on Guzzle 8 is downgraded when it installs saml2:This widens the constraint to
~2.8 || ^3.0. The only user isAnyURIValue, which callsnew Uri()andUriNormalizer::isEquivalent(), and both are unchanged in psr7 3. simplesamlphp/assert 2.x pins psr7 the same way, so psr7 3 installs only once both are widened. The assert change is simplesamlphp/assert#44.Tested
Tested with this change plus the assert change, installed from a local path repository:
PHPStan reports no errors with either major.
The 4 errors fail the same way on psr7 2 and on unmodified
release-2.8. They are thetestExternalEntityCannotReadLocalFile*tests inDOMDocumentFactoryTest:Class "SimpleSAML\Test\XML\DOMDocument" not found. The test file usesDOMDocumentinside a namespace without auseor a leading backslash.saml2's own suite gives the same results on both majors with both changes installed:
release-6.3: 1166 tests OK, 2 skipped.release-6.2: the same 3 errors and 2 failures as on psr7 2.saml2 and xml-security do not use psr7 directly.
Behaviour with psr7 3
psr7 3 parses URIs more strictly, so
AnyURIValuerejects a few values that 2.x accepted. Each of them is already invalid under RFC 3986:isEquivalent()also canonicalises IPv6 hosts, so[0:0:0:0:0:0:0:1]and[::1]compare equal.Other lines
release-2.7pins~2.8too, and saml2 6.1.x uses it (~2.7.0). The same change passes there, as the table shows. I can open it against that branch as well.release-1.xdoes not require psr7 directly. It reaches psr7 through assert 1.x, which the assert PR covers.release-3.xand master do not require psr7.