Skip to content
This repository was archived by the owner on Aug 15, 2022. It is now read-only.

Conversation

@theist
Copy link
Contributor

@theist theist commented Mar 27, 2017

Seems that some markdown headings lacks of a space, causing to render the #symbols literally once markdown is rendered

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Corrected some of the readmes headings

Related Issues

e.g. Fixes #206 and closes #230

Does not apply

Test strategy

e.g. Add tests around whatsit production.

Does not apply

Seems that some markdown headings lacks of a space, causing to render the #symbols literally once markdown is rendered
@coveralls
Copy link

coveralls commented Mar 27, 2017

Coverage Status

Coverage remained the same at 29.268% when pulling b05b73e on theist:patch-1 into 1d28f68 on slackhq:master.

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Roach Roach merged commit f9f2fd5 into slack-samples:master Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants