Fix tests (well, at least the testrunner)#112
Merged
eavichay merged 7 commits intoslimjs:masterfrom May 1, 2022
mj026:fix-tests
Merged
Fix tests (well, at least the testrunner)#112eavichay merged 7 commits intoslimjs:masterfrom mj026:fix-tests
eavichay merged 7 commits intoslimjs:masterfrom
mj026:fix-tests
Conversation
added 7 commits
November 16, 2021 11:08
eavichay
reviewed
Nov 16, 2021
| globals: { | ||
| window: {}, | ||
| }, | ||
| testEnvironment: 'jsdom' |
Member
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
Suggested change
| testEnvironment: 'jsdom' | |
| testEnvironment: "jsdom" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've looked into the slim.js testsuite and I:
jsdom-globaland added the jest plugin'should update with function calls',test failure, but that is not something I'm capable of (right now). (https://github.com/maerteijn/slim.js/runs/4167270300?check_suite_focus=true) I would not know why the changes onstub.valuedon't give any changes to the div element. Maybe you could take a look what is going on there?