Use if_indextoname to log the interface name for DNS-SD functions #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, this helps because you see the familiar name in the log, e.g.
eth0.On Windows, it's not much use because
if_indextonamereturns a name like "ethernet_32778" that seems to be pretty meaningless. We have cpprest/host_utils.cpp code using theGetAdaptersAddressesAPI to getAdapterName, but notFriendlyName, already but we don't currently have any dependencies from the mdns library on the nmos-cpp library, so I didn't want to do add coupling just for this. For now, I think you can continue to use PowerShellGet-NetAdapter -InterfaceIndex Nto look up interface index N.