feat(command): adding args to use line

[danmx]

Adding args to use line.

Old:

❯ ./test
Error: accepts 1 arg(s), received 0
Usage:
  test [flags]

Flags:
  -h, --help     help for test
  -t, --toggle   Help message for toggle

New:

❯ ./test
Error: accepts 1 arg(s), received 0
Usage:
test [flags] [args]

Flags:
-h, --help     help for test
-t, --toggle   Help message for toggle

Diff:

3c3
<   test [flags]
---
>   test [flags] [args]

[CLAassistant]

All committers have signed the CLA.

[github-actions]

This PR is being marked as stale due to a long period of inactivity

[danmx]

@jpmcb could you take a look?

[umarcor]

Ref #842

[jpmcb]

Hi @danmx thanks for this PR - would you be able to add a test for this? Maybe in command_test.go? A passing test will help this get reviewed and merged in

[danmx]

@jpmcb took me some time but I've added tests for UseLine.

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[danmx]

@marckhouzam I see that you were active recently. Could you take a look at this PR?

I addressed the previous comment about adding tests.
I had to reshuffle Command struct optimal memory usage (fixing violations of maligned linter) because I added another bool field.

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[marckhouzam]

@danmx could you show the change in output that this provides in the description of the PR so I can know what to expect?

[danmx]

@marckhouzam the change is:

Old:

❯ ./test
Error: accepts 1 arg(s), received 0
Usage:
  test [flags]

Flags:
  -h, --help     help for test
  -t, --toggle   Help message for toggle

New:

❯ ./test
Error: accepts 1 arg(s), received 0
Usage:
test [flags] [args]

Flags:
-h, --help     help for test
-t, --toggle   Help message for toggle

Diff:

3c3
<   test [flags]
---
>   test [flags] [args]

[github-actions]

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[marckhouzam]

Could you not reorder the fields of the command structure? Although your order may be better it makes the review harder. It’s hard for me to find time for reviews so if you keep the PR as small as possible it’ll increase your chances of getting it merged.

[marckhouzam]

test [flags] [args]

I don’t think we can do this. The command.Use field is defined by the program and many programs specify the arguments the command expects in their Use field. In such cases the new [args] would be repeating.

For example https://github.com/helm/helm/blob/a3c903e4c62839d24389a1e0cdf550a8d759f054/cmd/helm/pull.go#L49