Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the "required flag(s) "%s" not set" error message by not printing "(s)" if a single required flag is missing #1217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nestoroprysk
Copy link

@nestoroprysk nestoroprysk commented Sep 3, 2020

Improving the "required flag(s) "%s" not set" error message by not printing "(s)" if a single required flag is missing.

If a single flag is missing, the error message is of the form "required flag "%s" not set".

Otherwise, the error message remains unchanged.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nestoroprysk
Copy link
Author

signed in the agreement

@jharshman
Copy link
Collaborator

@nestoroprysk please add a description to your PR.
Add details that will help maintainers get on the same page as you about this change.

@nestoroprysk nestoroprysk changed the title Improving the required flags error by using the pluralize util Improving the "required flag(s) "%s" not set" error message by not printing "(s)" if a single required flag is missing Oct 4, 2020
@nestoroprysk
Copy link
Author

@jharshman updated the description and resolved conflicts

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

This PR is being marked as stale due to a long period of inactivity

@marckhouzam
Copy link
Collaborator

I think this makes sense but needs a proper review. Re-opening.

@marckhouzam marckhouzam reopened this Mar 30, 2022
@marckhouzam marckhouzam added area/flags-args Changes to functionality around command line flags and args and removed kind/stale labels Mar 30, 2022
@github-actions github-actions bot added the size/M Denotes a PR that chanes 24-99 lines label Mar 30, 2022
@marckhouzam marckhouzam added the area/cobra-command Core `cobra.Command` implementations label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cobra-command Core `cobra.Command` implementations area/flags-args Changes to functionality around command line flags and args size/M Denotes a PR that chanes 24-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants