Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflow_dispatch #1387

Merged
merged 1 commit into from
Sep 16, 2022
Merged

ci: add workflow_dispatch #1387

merged 1 commit into from
Sep 16, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented May 3, 2021

The workflow dispatch event allows maintainers or forkers to trigger CI runs either through the web GUI or through the API. See https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch.

@github-actions github-actions bot added the admin For general admin tasks to be done usualy by maintainers label May 3, 2021
@umarcor umarcor mentioned this pull request Jun 29, 2021
Closed
@umarcor umarcor force-pushed the dispatch branch 3 times, most recently from afdf43a to b0698b0 Compare July 1, 2021 17:53
@umarcor
Copy link
Contributor Author

umarcor commented Aug 4, 2021

ping @jpmcb

@umarcor umarcor mentioned this pull request Sep 25, 2021
Closed
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 4, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
340d9b8
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 5, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
ac8db9e
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 15, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
da54b59
@jpmcb
Copy link
Collaborator

jpmcb commented Nov 16, 2021

You can manually trigger workflow runs. To trigger specific workflows in a repository, use the workflow_dispatch event.

I'm not sure why we need this? Why would a maintainer need to manually trigger the github actions?

@umarcor
Copy link
Contributor Author

umarcor commented Nov 16, 2021

I'm not sure why we need this? Why would a maintainer need to manually trigger the github actions?

The CI workflow depends on some external dependencies which might change without modifications in the codebase of this repository. Currently, the only solution to have those tested is to rerun an existing workflow, or to push/ammend a "dummy" branch. Having this option avoids that.

Moreover, having this added to the workflow in the default branch will allow users to use the feature in their forks. Hence, even though manually triggering CI might not be used by maintainers of this repo, it can be useful for contributors.

umarcor added a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
9db8f65
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
8cbfedf
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 25, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
5da5351
@jpmcb jpmcb added this to the 2.0.0 milestone Dec 7, 2021
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
8ae7aeb
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
d5c723e
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
685f3e5
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 7, 2021
@umarcor
ci: add workflow_dispatch (spf13#1387)
5e97685
@umarcor umarcor force-pushed the dispatch branch 2 times, most recently from 581a01a to f7b7285 Compare March 30, 2022 00:30
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Mar 30, 2022
@umarcor
Copy link
Contributor Author

umarcor commented Apr 21, 2022

Can we please have this one-liner merged?

@umarcor umarcor force-pushed the dispatch branch 3 times, most recently from a91c7ad to fcb2303 Compare May 5, 2022 07:02
@umarcor umarcor force-pushed the dispatch branch 2 times, most recently from de4f5c1 to 51c4abc Compare May 18, 2022 14:51
@umarcor
Copy link
Contributor Author

umarcor commented Jun 6, 2022

ping @spf13 @johnSchnake @jpmcb @marckhouzam

@umarcor umarcor force-pushed the dispatch branch 3 times, most recently from e56930d to e4e043f Compare June 21, 2022 07:39
@umarcor umarcor mentioned this pull request Jun 21, 2022
Closed
@marckhouzam marckhouzam modified the milestones: 1.5.0, 1.6.0 Jun 21, 2022
@jpmcb jpmcb added the lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready label Sep 11, 2022
marckhouzam
marckhouzam approved these changes Sep 11, 2022
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not.

@umarcor umarcor mentioned this pull request Sep 14, 2022
Merged
@marckhouzam marckhouzam merged commit 459fc5f into spf13:main Sep 16, 2022
@umarcor umarcor deleted the dispatch branch September 17, 2022 07:31
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
@jimschubert
Merge branch 'main' into doc-slash-commands
b5bc3e3 
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
admin For general admin tasks to be done usualy by maintainers area/github For changes to Github specific things not shipped in the library lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@umarcor @jpmcb @marckhouzam