Skip to content
This repository was archived by the owner on Mar 27, 2021. It is now read-only.

Conversation

@hexedpackets
Copy link
Contributor

No description provided.

@hexedpackets hexedpackets requested a review from a team April 24, 2020 20:47
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #647 into master will increase coverage by 0.83%.
The diff coverage is 87.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #647      +/-   ##
============================================
+ Coverage     53.05%   53.89%   +0.83%     
- Complexity     2939     2962      +23     
============================================
  Files           726      726              
  Lines         19526    19413     -113     
  Branches       1289     1276      -13     
============================================
+ Hits          10359    10462     +103     
+ Misses         8727     8507     -220     
- Partials        440      444       +4     
Impacted Files Coverage Δ Complexity Δ
...ic/analytics/bigtable/BigtableMetricAnalytics.java 21.87% <0.00%> (ø) 3.00 <0.00> (ø)
...igtable/api/BigtableTableTableAdminClientImpl.java 90.90% <ø> (+90.90%) 4.00 <0.00> (+4.00)
...ic/analytics/bigtable/BigtableAnalyticsModule.java 64.91% <83.33%> (+0.91%) 9.00 <3.00> (ø)
...oic/metric/bigtable/BigtableConnectionBuilder.java 94.44% <91.66%> (+94.44%) 3.00 <2.00> (+3.00)
...ify/heroic/metric/bigtable/BigtableConnection.java 93.75% <93.75%> (ø) 5.00 <5.00> (?)
...m/spotify/heroic/test/AbstractMetricBackendIT.java 98.23% <100.00%> (ø) 27.00 <6.00> (-1.00)
...potify/heroic/metric/bigtable/BigtableBackend.java 91.63% <100.00%> (ø) 57.00 <3.00> (ø)
...y/heroic/metric/bigtable/BigtableMetricModule.java 79.71% <100.00%> (+7.10%) 5.00 <0.00> (ø)
...com/spotify/heroic/aggregation/simple/MaxBucket.kt 44.44% <0.00%> (-11.12%) 4.00% <0.00%> (-1.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2d81b...f38977b. Read the comment docs.

Copy link
Contributor

@dmichel1 dmichel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had one comment about the docs that should be addressed.

@hexedpackets hexedpackets merged commit 26d23e1 into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the bigtable branch April 27, 2020 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants