This repository was archived by the owner on Mar 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
Drop metric with row key length bigger than BT limit #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoeboo
approved these changes
Aug 20, 2020
lmuhlha
reviewed
Aug 20, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableBackend.java
Show resolved
Hide resolved
lmuhlha
reviewed
Aug 20, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableBackend.java
Show resolved
Hide resolved
Member
|
Seems like checkstyle is still failing :( |
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
============================================
+ Coverage 53.88% 53.90% +0.01%
- Complexity 2962 2966 +4
============================================
Files 726 726
Lines 19426 19454 +28
Branches 1279 1282 +3
============================================
+ Hits 10468 10486 +18
- Misses 8513 8521 +8
- Partials 445 447 +2
Continue to review full report at Codecov.
|
sming
suggested changes
Aug 21, 2020
Contributor
sming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly just a compile-time alternative suggestion for the hugeRowKey flag and assertion - which only trips you up at run/debug time.
heroic-component/src/main/java/com/spotify/heroic/statistics/MetricBackendReporter.java
Outdated
Show resolved
Hide resolved
heroic-test/src/main/java/com/spotify/heroic/test/AbstractMetricBackendIT.java
Show resolved
Hide resolved
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableBackend.java
Show resolved
Hide resolved
...ntic/src/main/java/com/spotify/heroic/statistics/semantic/SemanticMetricBackendReporter.java
Show resolved
Hide resolved
sming
approved these changes
Aug 24, 2020
Contributor
sming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will drop metric with row key length longer than 4096 bytes.
It will also create counter metric so we could alert on high numbers.