Skip to content
This repository was archived by the owner on Mar 27, 2021. It is now read-only.

Conversation

@malish8632
Copy link
Contributor

This change moving creation of QuotaWatcher closer to its usage minimizing chance of exceptional exit before it is used.
Wraps main call to try/catch in order to properly clean QuotaWatcher map.
It also uses QuotaWatcher as key in ConcurrentMap.

Copy link
Contributor

@sming sming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #702 into master will decrease coverage by 0.05%.
The diff coverage is 65.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #702      +/-   ##
============================================
- Coverage     54.21%   54.15%   -0.06%     
+ Complexity     3040     3037       -3     
============================================
  Files           735      735              
  Lines         19809    19808       -1     
  Branches       1305     1304       -1     
============================================
- Hits          10740    10728      -12     
- Misses         8602     8614      +12     
+ Partials        467      466       -1     
Impacted Files Coverage Δ Complexity Δ
.../com/spotify/heroic/metric/LocalMetricManager.java 66.07% <65.00%> (-0.40%) 4.00 <0.00> (ø)
...src/main/java/com/spotify/heroic/metrics/EWMA.java 58.33% <0.00%> (-20.84%) 4.00% <0.00%> (-1.00%)
...rc/main/java/com/spotify/heroic/metrics/Meter.java 68.96% <0.00%> (-17.25%) 6.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e271b...c0d6861. Read the comment docs.

@malish8632 malish8632 merged commit 15bae90 into master Oct 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the debug-quotawatchers branch October 20, 2020 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants