This repository was archived by the owner on Mar 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
implemented configurable Bigtable write batch size. #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuhlha
reviewed
Oct 21, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableMetricModule.java
Outdated
Show resolved
Hide resolved
Member
|
Looks reasonable to me 👍 might be good to get another pair of eyes on it but +1 |
malish8632
approved these changes
Oct 22, 2020
Contributor
malish8632
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
adsail
approved these changes
Oct 22, 2020
Contributor
adsail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
============================================
+ Coverage 54.21% 54.40% +0.19%
- Complexity 3040 3052 +12
============================================
Files 735 735
Lines 19808 19866 +58
Branches 1304 1304
============================================
+ Hits 10738 10808 +70
+ Misses 8603 8591 -12
Partials 467 467
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make BulkMutation Batch Size Configurable (v0.5.1)
Design & Implementation Notes