Skip to content
This repository was archived by the owner on Mar 27, 2021. It is now read-only.

Conversation

@sming
Copy link
Contributor

@sming sming commented Oct 21, 2020

Make BulkMutation Batch Size Configurable (v0.5.1)

  • I am a prism dev
  • Who wants to stabilize heroic
  • So that I can focus on new functionality

Design & Implementation Notes

@sming sming self-assigned this Oct 21, 2020
@sming sming linked an issue Oct 21, 2020 that may be closed by this pull request
@lmuhlha
Copy link
Member

lmuhlha commented Oct 21, 2020

Looks reasonable to me 👍 might be good to get another pair of eyes on it but +1

Copy link
Contributor

@malish8632 malish8632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@adsail adsail self-requested a review October 22, 2020 16:06
Copy link
Contributor

@adsail adsail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #706 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
+ Coverage     54.21%   54.40%   +0.19%     
- Complexity     3040     3052      +12     
============================================
  Files           735      735              
  Lines         19808    19866      +58     
  Branches       1304     1304              
============================================
+ Hits          10738    10808      +70     
+ Misses         8603     8591      -12     
  Partials        467      467              
Impacted Files Coverage Δ Complexity Δ
...com/spotify/heroic/metric/MetricManagerModule.java 74.10% <100.00%> (+3.69%) 18.00 <2.00> (+2.00)
...ytics/bigtable/BigtableAnalyticsMetricBackend.java 27.27% <100.00%> (+3.46%) 3.00 <1.00> (+1.00)
...potify/heroic/metric/bigtable/BigtableBackend.java 88.92% <100.00%> (+0.08%) 61.00 <1.00> (+1.00)
...oic/metric/bigtable/BigtableConnectionBuilder.java 94.44% <100.00%> (+4.70%) 5.00 <2.00> (+2.00)
...y/heroic/metric/bigtable/BigtableMetricModule.java 85.85% <100.00%> (+7.77%) 7.00 <3.00> (+2.00)
.../com/spotify/heroic/common/EmptyOptionalLimit.java 70.58% <0.00%> (+8.82%) 19.00% <0.00%> (+2.00%)
.../com/spotify/heroic/common/ValueOptionalLimit.java 55.55% <0.00%> (+9.25%) 20.00% <0.00%> (+1.00%)
...igtable/credentials/DefaultCredentialsBuilder.java 100.00% <0.00%> (+33.33%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daad6f...81f85a6. Read the comment docs.

@sming sming merged commit 6e46341 into master Oct 27, 2020
@sming sming deleted the feature/add-configurable-bt-batch-size branch October 27, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make BulkMutation Batch Size Configurable

5 participants