helios: set SUPPRESS_GCLOUD_CREDS_WARNING environment variable#32
helios: set SUPPRESS_GCLOUD_CREDS_WARNING environment variable#32mattnworb merged 2 commits intospotify:masterfrom
Conversation
Have to stop using [write_jar_script][0] as it does not support passing in environment variables. Writing the script inline instead, which I picked up from the scio formula. [0]: https://www.rubydoc.info/github/Homebrew/brew/Pathname:write_jar_script
|
before merging, I need to doublecheck how our @spotify-helios-ci-agent robot bumps the version number in each release to make sure I didn't break anything it expects to be there. |
| (bin+"helios").write <<~EOS | ||
| #!/usr/bin/env bash | ||
| export SUPPRESS_GCLOUD_CREDS_WARNING=true | ||
| exec java -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Xverify:none -jar #{libexec}/#{jarfile} "$@" |
There was a problem hiding this comment.
Is libexec defined somewhere? Previously it was a literal string.
There was a problem hiding this comment.
that doc in general was really helpful to understand this formula better
|
confirmed that our internal release script just does |
|
apparently the environment variable I am setting in this change is brand new, and not yet in a gcloud oauth2 library release googleapis/google-auth-library-java#207 We'll have to update the version of the library used by helios for this to be picked up. |
Have to stop using write_jar_script as it does not support passing
in environment variables.
Writing the script inline instead, which I picked up from the scio
formula.