Conversation
hstove
previously approved these changes
Jan 31, 2025
Contributor
hstove
left a comment
There was a problem hiding this comment.
Nice! This is a much more readable version, too.
jbencin
reviewed
Jan 31, 2025
…test retry sleep from 100ms to 500ms (less log spam in tests)
Contributor
Author
|
Just look at that glorious green check mark without any re-runs. |
jbencin
approved these changes
Jan 31, 2025
This was referenced Feb 4, 2025
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the block waits in the nakamoto_integrations and signer tests. This should reduce a little bit of flakiness across the board.