OsmNoteQuestController: surveyme override and regex test update#6075
OsmNoteQuestController: surveyme override and regex test update#6075westnordost merged 3 commits intostreetcomplete:masterfrom
Conversation
Resolves streetcomplete#6052. * Restructured exclusion of notes that get overridden by #surveyme * Added RegexOption.DOT_MATCHES_ALL to function NoteComment.containsSurveyRequiredMarker: #surveyme wasn't found at the end of the text added by the user, because SC add "\n\nvia StreetComplete <x.y>" to the text
...c/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt
Outdated
Show resolved
Hide resolved
...c/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt
Show resolved
Hide resolved
|
@westnordost as Florian rightfully asked, I tried adding some tests for the changes I made and got a ton of errors hinting to the mockito-version being out of date. I changed those to the most recent (mockito-core and mockitor-android 5.14.2, mockito-inline is now merged into -core), which makes all tests work again for me. Is there any reason for not using the newest mockito packages? |
* containsSurveyRequiredMarker now also ignores case * added three tests
Simplify containsSurveryRequiredMarker
|
No, I think there wasn't a reason for the old version. Never bothered to upgrade because it was working fine and I didn't need any new features. |
|
Put the new version as a suggestion in your #6074. |
|
Slightly off-topic, but I'm curious. @kmpoppe, I used this comment as reference until now: kmpoppe/noteSolver#26 (comment) |
Resolves #6052.