Use eslint in favour of JSHint #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@slnode test please |
Contributor
Author
|
Unrelated windows failures, gonna land this and backport. |
superkhau
added a commit
that referenced
this pull request
Oct 13, 2016
* Add ESLint and remove JSHint/JSCS * Add linting fixes via ESLint's fix command * Use ESLint in favour of JSHint Backport of #129
superkhau
added a commit
that referenced
this pull request
Oct 13, 2016
Contributor
|
@superkhau: For future reference, could you please squash commits to single commit before merging. Thanks. |
Contributor
Author
Contributor
|
@superkhau : yeah. Weird that GH shows 3 commits, see: |
Contributor
Author
|
Because I used the "squash" button on the GH UI. I believe it leaves the original intact. |
0candy
added a commit
that referenced
this pull request
Oct 14, 2016
* Use eslint in favour of JSHint (#129) (Simon Ho) * Update translation files - round#2 (Candy) * Add translated files (gunjpan) * Update deps to LB 3.0.0 RC (Miroslav Bajtoš) * Use [email protected] for running the tests. (Miroslav Bajtoš)
bajtos
added a commit
that referenced
this pull request
Dec 21, 2016
* Update paid support URL (Siddhi Pai) * add: HTTP2 APNS (Ilir Nuhiu) * Fix timeout in tests on Windows (Miroslav Bajtos) * Drop support for Node v0.10 & v0.12 (Miroslav Bajtoš) * Start the development of the next major version (Miroslav Bajtoš) * Remove Gruntfile and grunt deps (Miroslav Bajtoš) * Update README.md (Simon Ho) * Use eslint in favour of JSHint (#129) (Simon Ho) * Update translation files - round#2 (Candy) * Add translated files (gunjpan) * Update deps to LB 3.0.0 RC (Miroslav Bajtoš) * Use [email protected] for running the tests. (Miroslav Bajtoš)
MichaelMarner
pushed a commit
to NextFaze/loopback-component-push
that referenced
this pull request
Feb 1, 2017
* Use eslint in favour of JSHint (strongloop#129) (Simon Ho) * Update translation files - round#2 (Candy) * Add translated files (gunjpan) * Update deps to LB 3.0.0 RC (Miroslav Bajtoš) * Use [email protected] for running the tests. (Miroslav Bajtoš)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Amir-61 @gunjpan PTAL