Skip to content

Change profile avatar title from fullname to username#53

Merged
wachterjohannes merged 1 commit intosulu:developfrom
alexander-schranz:bugfix/profile-avatar-title
Mar 6, 2017
Merged

Change profile avatar title from fullname to username#53
wachterjohannes merged 1 commit intosulu:developfrom
alexander-schranz:bugfix/profile-avatar-title

Conversation

@alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Mar 6, 2017

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
License MIT

What's in this PR?

Change fullname to username in media upload.

Why?

Privacy!

BC Breaks/Deprecations

When uploaded a profile picture the filename will be the username not the fullname now.

To Do

  • Migration SQL

@alexander-schranz alexander-schranz force-pushed the bugfix/profile-avatar-title branch from d2d9b83 to b69c355 Compare March 6, 2017 14:34
Copy link
Member

@wachterjohannes wachterjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

UPGRADE.md Outdated
@@ -0,0 +1,28 @@
# Upgrade

## dev-develop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will release this asap as 0.2.0 so you can set it to 0.2.0

@alexander-schranz alexander-schranz force-pushed the bugfix/profile-avatar-title branch from b69c355 to 1d71d9a Compare March 6, 2017 14:55
@wachterjohannes wachterjohannes merged commit b459530 into sulu:develop Mar 6, 2017
@alexander-schranz alexander-schranz deleted the bugfix/profile-avatar-title branch March 6, 2017 15:50
alexander-schranz added a commit to alexander-schranz/SuluCommunityBundle that referenced this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants