Allow binding to a random port (#3825)

swoole · Nov 9, 2020 · 31cf895 · 31cf895
1 parent 1464b56
commit 31cf895
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ext-src/swoole_client.cc b/ext-src/swoole_client.cc
@@ -455,7 +455,7 @@ void php_swoole_client_check_setting(Client *cli, zval *zset) {
     if (php_swoole_array_get_value(vht, "bind_address", ztmp)) {
         bind_address = zend::String(ztmp).to_std_string();
     }
-    if (bind_port > 0 || bind_address.length() > 0) {
+    if (bind_address.length() > 0) {
         cli->socket->bind(bind_address, &bind_port);
     }
     /**

diff --git a/ext-src/swoole_client_coro.cc b/ext-src/swoole_client_coro.cc
@@ -296,7 +296,7 @@ bool php_swoole_client_set(Socket *cli, zval *zset) {
         zend::String tmp = ztmp;
         _bind_address = tmp.to_std_string();
     }
-    if ((_bind_port > 0 || !_bind_address.empty()) && !cli->bind(_bind_address, _bind_port)) {
+    if (!_bind_address.empty() && !cli->bind(_bind_address, _bind_port)) {
         ret = false;
     }
     /**