Improve coroutine state constants.

swoole · Nov 24, 2018 · 9ea8df1 · 9ea8df1
1 parent 7f88d78
commit 9ea8df1
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/gdbinit b/gdbinit
@@ -24,7 +24,7 @@ define co_list
             end
             if $co->state == 1
                 color $RED
-                printf "%s\n", "SW_CORO_YIELD"
+                printf "%s\n", "SW_CORO_WAITING"
                 color_reset
             end      
             if $co->state == 2

diff --git a/include/coroutine.h b/include/coroutine.h
@@ -32,7 +32,7 @@
 
 typedef enum
 {
-    SW_CORO_INIT = 0, SW_CORO_YIELD, SW_CORO_RUNNING, SW_CORO_END,
+    SW_CORO_INIT = 0, SW_CORO_WAITING, SW_CORO_RUNNING, SW_CORO_END,
 } sw_coro_state;
 
 typedef void (*coro_php_create_t)();

diff --git a/src/coroutine/base.cc b/src/coroutine/base.cc
@@ -54,7 +54,7 @@ long Coroutine::create(coroutine_func_t fn, void* args)
 
 void Coroutine::yield()
 {
-    state = SW_CORO_YIELD;
+    state = SW_CORO_WAITING;
     if (swCoroG.onYield)
     {
         swCoroG.onYield(task);
@@ -80,7 +80,7 @@ void Coroutine::resume()
 
 void Coroutine::yield_naked()
 {
-    state = SW_CORO_YIELD;
+    state = SW_CORO_WAITING;
     swCoroG.call_stack_size--;
     ctx.SwapOut();
 }

diff --git a/swoole_coroutine_util.cc b/swoole_coroutine_util.cc
@@ -314,6 +314,10 @@ void swoole_coroutine_util_init(int module_number)
     SWOOLE_DEFINE(DEFAULT_MAX_CORO_NUM);
     SWOOLE_DEFINE(MAX_CORO_NUM_LIMIT);
     SWOOLE_DEFINE(MAX_CORO_NESTING_LEVEL);
+    SWOOLE_DEFINE(CORO_INIT);
+    SWOOLE_DEFINE(CORO_WAITING);
+    SWOOLE_DEFINE(CORO_RUNNING);
+    SWOOLE_DEFINE(CORO_END);
 
     //prohibit exit in coroutine
     INIT_CLASS_ENTRY(swoole_exit_exception_ce, "Swoole\\ExitException", swoole_exit_exception_methods);

diff --git a/tests/swoole_coroutine/onSwap/on_swap.phpt → ...s/swoole_coroutine/swap_callback/log.phpt b/tests/swoole_coroutine/onSwap/on_swap.phpt → ...s/swoole_coroutine/swap_callback/log.phpt
@@ -8,22 +8,22 @@ require __DIR__ . '/../../include/bootstrap.php';
 co::onSwap(function (int $state, int $cid, int $origin_cid) {
     $cid1 = $cid2 = -1;
     switch ($state){
-        case 0:
+        case SWOOLE_CORO_INIT:
             $state = 'create';
             $cid1 = $origin_cid;
             $cid2 = $cid;
             break;
-        case 1:
+        case SWOOLE_CORO_WATING:
             $state = 'yield';
             $cid1 = $cid;
             $cid2 = $origin_cid;
             break;
-        case 2:
+        case SWOOLE_CORO_RUNNING:
             $state = 'resume';
             $cid1 = $origin_cid;
             $cid2 = $cid;
             break;
-        case 3:
+        case SWOOLE_CORO_END:
             $state = 'close';
             $cid1 = $cid;
             $cid2 = $origin_cid;