Fix zend_hash_clean assertion failure (#3634)

swoole · Sep 7, 2020 · afd2a8c · afd2a8c
1 parent 56f4f36
commit afd2a8c
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/swoole_http_client_coro.cc b/swoole_http_client_coro.cc
@@ -917,16 +917,8 @@ bool HttpClient::send() {
 
     // when new request, clear all properties about the last response
     {
-        zval *zattr;
-        zattr = sw_zend_read_property_ex(swoole_http_client_coro_ce, zobject, SW_ZSTR_KNOWN(SW_ZEND_STR_HEADERS), 0);
-        if (ZVAL_IS_ARRAY(zattr)) {
-            zend_hash_clean(Z_ARRVAL_P(zattr));
-        }
-        zattr = sw_zend_read_property_ex(
-            swoole_http_client_coro_ce, zobject, SW_ZSTR_KNOWN(SW_ZEND_STR_SET_COOKIE_HEADERS), 0);
-        if (ZVAL_IS_ARRAY(zattr)) {
-            zend_hash_clean(Z_ARRVAL_P(zattr));
-        }
+        zend_update_property_null(swoole_http_client_coro_ce, SW_Z8_OBJ_P(zobject), ZEND_STRL("headers"));
+        zend_update_property_null(swoole_http_client_coro_ce, SW_Z8_OBJ_P(zobject), ZEND_STRL("set_cookie_headers"));
         zend_update_property_string(swoole_http_client_coro_ce, SW_Z8_OBJ_P(zobject), ZEND_STRL("body"), "");
     }