enable auth for the endpoints with support #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1869f85 to
3879588
Compare
Member
|
📣 NOTIFICATION Generated by @thefrontside/actions |
jbolda
commented
Jan 6, 2023
| secret: ${AUTH_SESSION_CLIENT_SECRET} | ||
| # see https://backstage.io/docs/auth/service-to-service-auth#setup | ||
| keys: | ||
| - secret: ${BACKEND_SECRET} |
Contributor
Author
There was a problem hiding this comment.
We will want to confirm that we have this token set.
Contributor
Author
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Each endpoint must support the IdentityApi. We have a few custom plugins which do not yet appear to support it. This enables auth on any of the endpoints that appear to support it.
I think this should land after #185, but I don't believe it technically matters.
Approach
Add an
authMiddleware.tsandcookieAuthas per the community docs.