Update index.turbo.ts #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Events.init() function adds event listeners to the window, not the document. So the handler that is supposed to fire initFlowbite never gets called. Need to dispatch event on window where the event listener was attached.
|
Hey @artinboghosian, Thanks for the PR. Merged! Will release in the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Turbo-Stream response is returned by Rails server the library intercepts before-render and fires a custom event after-render which calls initFlowbite. However, the before-render event handler dispatches the Event on the document rather than window where the after-render handler was defined. So the after-render handler never gets called.
This PR dispatches the Event on window where the after-render handler was defined.