Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Rankings Table to React #10569

Merged
merged 50 commits into from
Feb 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
7db290f
create rankings table
FinnIckler Jan 7, 2025
e0d12ca
create seperate index for filters
FinnIckler Jan 8, 2025
40b29cb
Merge branch 'main' into react/rankings
FinnIckler Jan 8, 2025
8b8c66e
implement backend loading and filters
FinnIckler Jan 8, 2025
4e1cb69
remove segment
FinnIckler Jan 8, 2025
f6f0d47
fix stylings in filters
FinnIckler Jan 10, 2025
4a87829
fix gender and region not being filtered
FinnIckler Jan 10, 2025
86e2ed8
added show filters
FinnIckler Jan 10, 2025
6f37b6d
implement by regions table
FinnIckler Jan 10, 2025
985887c
add i18n to resultsfilter
FinnIckler Jan 10, 2025
c3dfcf0
Merge branch 'thewca:main' into react/rankings
FinnIckler Jan 13, 2025
81f81a4
fix competitions_by_id serialization
FinnIckler Jan 13, 2025
a7b0a7c
don't include organizers or delegates in competition serialization
FinnIckler Jan 13, 2025
b476045
fix indentation
FinnIckler Jan 13, 2025
42e8d19
fix country being imported in routes
FinnIckler Jan 13, 2025
7fb1151
Update app/webpacker/components/Results/resultsFilter.jsx
FinnIckler Jan 13, 2025
1375c9f
mobile changes
FinnIckler Jan 13, 2025
e03bbd4
Update app/webpacker/components/Results/Rankings/RankingsTable.jsx
FinnIckler Jan 13, 2025
9330171
change useMemo to try and fix by region rendering
FinnIckler Jan 13, 2025
eb42088
force Table Body to rerender when changing show modes
FinnIckler Jan 13, 2025
5837c0a
use reduce instead of map
FinnIckler Jan 13, 2025
d1c7b7e
use a reducer instead of state
FinnIckler Jan 13, 2025
3461642
add title prop
FinnIckler Jan 13, 2025
03a1d3d
parse initial State from the URL
FinnIckler Jan 13, 2025
791a743
Update app/webpacker/components/Results/Rankings/RankingsTable.jsx
FinnIckler Jan 14, 2025
fed3a8d
Wrap table header into Row
gregorbg Jan 14, 2025
b8a4176
Improve filter box responsive layout
gregorbg Jan 14, 2025
026dabe
don't use let in useMemo
FinnIckler Jan 14, 2025
4d3436c
use initializer Function
FinnIckler Jan 14, 2025
78279c8
add country.name to key
FinnIckler Jan 15, 2025
b92d81a
Merge branch 'main' into react/rankings
FinnIckler Jan 15, 2025
43c5275
use react table to handle the keys
FinnIckler Jan 17, 2025
7479bf6
don't show mbld average
FinnIckler Jan 17, 2025
7a37464
Merge branch 'main' into react/rankings
FinnIckler Jan 17, 2025
7f711e9
fxi average header and remove cell call
FinnIckler Jan 20, 2025
131831a
introduce countries.byId
FinnIckler Jan 21, 2025
3fdd944
revert gregor change
FinnIckler Jan 21, 2025
513c057
don't use country.name
FinnIckler Jan 21, 2025
e5b36f8
actually use country.name
FinnIckler Jan 21, 2025
d89627a
use array spreading
FinnIckler Jan 21, 2025
95ac88e
introduce getCountryOrContinent helper function
FinnIckler Jan 21, 2025
edbbd1c
Merge branch 'thewca:main' into react/rankings
FinnIckler Jan 21, 2025
d8d12df
fix lint
FinnIckler Jan 21, 2025
362e3ff
move WCA_EVENT_IDS to wca-data.js.erb
FinnIckler Jan 21, 2025
4cbf25c
Merge branch 'main' into react/rankings
gregorbg Jan 28, 2025
d0c17b8
Delegate loading status to table only
gregorbg Jan 28, 2025
fb245d6
Leave React key computation to TanstackTable
gregorbg Jan 28, 2025
522679b
Implement colSpan for final column
gregorbg Jan 28, 2025
29c2cb8
Enable default value for 'By region' view
gregorbg Jan 28, 2025
b1a0591
Merge branch 'main' into react/rankings
gregorbg Feb 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into react/rankings
FinnIckler committed Jan 8, 2025
commit 40b29cb162bea9b9ed7c4482765156cdfad7b206

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.