Merged
Conversation
zsimjee
previously approved these changes
Jun 9, 2023
The merge-base changed after approval.
zsimjee
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Link to Notion Task or Github Issue
https://www.notion.so/tinystacks/Widget-Create-Update-Improvements-a54c945ccf634d9b9b06cec0fb382487
Summary of Feature
Other details
IMPORTANT: Since we have to use static imports in order for webpack to bundle the dependencies, all widget modules must contain a file at
/dist/ops-types.json. If need be, this file can be an empty json object; we can handle it from there, but the file itself must exist or ops-frontend will not build.Depends On
#36
tinystacks/ops-core-widgets#34
tinystacks/ops-aws-core-widgets#56
Screenshots