Support timezone aware datetime objects with Github provider #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobami
reviewed
Feb 16, 2020
tobami
reviewed
Feb 18, 2020
…aware_datetime_objects
…odespeed into support_tz_aware_datetime_objects
tobami
approved these changes
Feb 18, 2020
This was referenced Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new
US_TZ_AWARE_DATESsetting, which when setTrue, updates the Github provider code to support timezone aware datetime objects.For backward compatibility reasons, it defaults to
False.Background
Currently, if you use Github provider and have
USE_TZconfig option set toTrue, incorrect dates will be displayed in the CodeSpeed dashboard.The reason for that is that currently the Github provider code strips time zone info and makes datetime objects naive (aka not timezone aware). This means that datetime objects in the database carry no timezone info so all the timezone aware template functions will return invalid date.
This basically means that right now you can only use
USE_TZ=Falseand UTC dates everywhere with the Github provider.