Make sure comparison view works correctly when a default VCS branch is not called "default" #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to get
COMP_EXECUTABLEsetting to work with the following values, but It didn't appear to work:After digging into the code, I noticed that the code hard codes the default branch value name to
default.This obviously won't work when a default branch is not called
default. I assume thisdefaultvalue is a carry-over / legacy from Mercurial support (please correct me if I'm missing or misunderstanding something)...In this pull request, I updated it to use
default_branchvalue of theProjectmodel.I believe this is a correct change and I tested it with a project where value of
default_branchisperformance_trackingand it works correctly.With this change, name in the left "Executables" select box menu will now also be correct and won't include
... in branch ...part when a default branch is used.Here is an example with the same
COMP_EXECUTABLESsetting value andProject.default_branchbeing set toperformance_tracking.Before:
After:
TODO