Make maximum length for executable names in the sidebar configurable #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Executable sidebar in the Changes, Timeline and Comparision views configurable. This comes handy in scenarios where longer executable names are used (in such scenarios, names might be truncated which makes executable indistinguishable at a glance).
for it. This way it's easier to test those functions and also gives us more flexibility to introduce different truncating mechanism (e.g. truncate in the middle instead of at the end).
Contributor
Author
|
Refactored it into utility function (to make it easier to test and give us more flexibility with truncation algorithms in the future) and added tests in 36007a0. |
This was referenced Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes maximum length values which are used for truncating long executable names in the sidebar in the Changes, Timeline and Comparison views configurable.
Right now those default to relatively small values which means that names might get truncated too early which may make those executable names indistinguishable at a glance when the same common prefix is used for all the executable names (e.g. ``Python 2.7.17 - conf 1, Python 2.7.17 - conf 2, etc. - in this scenarios, last part which is the unique would would get truncated).
I know there are other ways around that (e.g. not having a common prefix, etc.), but I still think it doesn't hurt to make those limits user configurable.
Another potentially complementary change would also be allowing user to decide how to truncate executable names - e.g. truncate at the end (current behavior) or in the middle (potential new behavior).