Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Discord Added for Social links and footer and use react-icons instead #427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nijamaDev
Copy link

Made a simple change so the icons in the social links use react-icons instead of having the pure svg defined in the file, also changed the icons import in the footer to have cleaner and more consistent code.

List of changes:

  • Replaced '@react-icons/all-files' with updated 'react-icons'
  • Cleaner imports for icons
  • Use react-icons components instead of pure svg for the social links
  • Added Discord to the social links and footer
  • Better comments in site.config.ts

@vercel
Copy link

vercel bot commented Dec 19, 2022

@nijamaDev is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

@nijamaDev nijamaDev changed the title react-icons for Social links and footer and Discord Added Discord Added and react-icons for Social links and footer Dec 19, 2022
@nijamaDev nijamaDev changed the title Discord Added and react-icons for Social links and footer Enhancement: Discord Added for Social links and footer and use react-icons instead Dec 27, 2022
@GitMac32
Copy link

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks
Intentionally setting a security policy restricting script sources
checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

@nijamaDev
Copy link
Author

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks Intentionally setting a security policy restricting script sources checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

Excuse me? What are you talking about?

I think you might be in the wrong PR. I just added a way of setting up discord to the social links and on the footer and updated the react icons

@socket-security
Copy link

socket-security bot commented Jul 14, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@transitive-bullshit
Copy link
Owner

Thanks @nijamaDev. This PR looks great. Sorry I don't have time to maintain this project properly and I really have no idea what the other user was talking about.

I'm going through and doing a bunch of updates at the moment, so will consider these changes in a bit.

Copy link

socket-security bot commented Aug 5, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

nijamaDev and others added 2 commits November 12, 2024 16:28
- replaced @react-icons/all files with react-icons
- use react  icons instead of pure svg for the social links
- Added Discord to the social links and footer

correct imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants