DRY social icons #644
Open
DRY social icons #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@react-icons/[email protected] |
|
@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
…cellent hover-color suggestion from Cursor editor
…on from from the css
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gauravmm did couple of nice refactorings in #629 like removing the repetition for the social icons. I took his changes and removed the
DangerouslySetInnerHtmland now we have a nice way to configure the icons and colors from one single place.If we want to merge this in smaller pieces merge #642 first.
I also added a short demo video to prove that they still work like they should:
