Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump LLVM version to llvm/llvm-project@49af650 #2570

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Bump LLVM version to llvm/llvm-project@49af650 #2570

merged 3 commits into from
Oct 31, 2023

Conversation

gflegar
Copy link
Collaborator

@gflegar gflegar commented Oct 31, 2023

No description provided.

ashay and others added 2 commits October 30, 2023 16:50
@ashay @khasanovaa
[CI] add text file containing LLVM commit hash
edd89fc 
This patch adds a text file that holds the LLVM commit hash to be used
with the Triton code.  Once the workflow files are added to the main
branch, any updates to this text file in the llvm-head branch will
trigger an LLVM build and the corresponding build artifacts will be
uploaded to Azure Blob storage.

Squashed commits:
Bump LLVM version.
Update LLVM version to llvm/llvm-project@0954dc3
update hash to 76ce4736721a
update llvm hash: b1115f8ccefb380824a9d997622cc84fc0d84a89
[ci] now set LLVM_BUILD_TOOLS=ON in llvm-build.yml
@gflegar @khasanovaa
Bump LLVM version to llvm/llvm-project@49af650 (#2530)
5d1ca98
@gflegar gflegar requested a review from ptillet as a code owner October 31, 2023 14:24
@khasanovaa @gflegar
[BACKEND] Fix addStringToModule after change to LLVM::AddressOfOp…
12a8441 
…. `LLVM::AddressOfOp` now returns an opaque pointer by default.
@github-actions GitHub Actions
Copy link

⚠️ This PR does not produce bitwise identical kernels as the branch it's merged against. Please check artifacts for details. Download the output file here.

jlebar
jlebar reviewed Oct 31, 2023
View reviewed changes
python/setup.py
@@ -86,7 +86,7 @@ def get_llvm_package_info():
return Package("llvm", "LLVM-C.lib", "", "LLVM_INCLUDE_DIRS", "LLVM_LIBRARY_DIR", "LLVM_SYSPATH")
# use_assert_enabled_llvm = check_env_flag("TRITON_USE_ASSERT_ENABLED_LLVM", "False")
# release_suffix = "assert" if use_assert_enabled_llvm else "release"
rev = "b1115f8c"
rev = "49af6502"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we read the value in llvm-hash.txt? (And update the README.md that currently points here?)

jlebar
jlebar reviewed Oct 31, 2023
View reviewed changes
llvm-hash.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid polluting the top-level directory, could we put this in the cmake directory? (Perhaps that should be renamed to build.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both comments make sense to me. But I think it would be best to do those in a separate PR, since updating the LLVM version itself is quite orthogonal from the process for doing it, and would require modifying the build system in several unrelated locations. WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gflegar did you get around to making these changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karupayun should get to it next week.

@ptillet ptillet merged commit 601b95c into main Oct 31, 2023
4 checks passed
@ptillet ptillet deleted the llvm-49af650 branch October 31, 2023 19:06
karupayun added a commit to karupayun/triton that referenced this pull request Nov 22, 2023
@karupayun
Deduplicate llvm-hash value and move it under cmake folder
82838b2 
In this PR we are deduplicating the llvm-hash value (currently it's
in the llvm-hash.txt file but also under python/setup.py. The new
location is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
triton-lang#2570.
karupayun added a commit that referenced this pull request Nov 23, 2023
@karupayun
Deduplicate llvm-hash value and move it under cmake folder
c0d530f 
In this PR we are deduplicating the llvm-hash value (currently it's
in the llvm-hash.txt file but also under python/setup.py. The new
location is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
#2570.
karupayun added a commit that referenced this pull request Nov 23, 2023
@karupayun
Deduplicate llvm-hash value and move it under cmake folder
d198918 
In this PR we are deduplicating the llvm-hash value (currently it's
in the llvm-hash.txt file but also under python/setup.py. The new
location is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
#2570.
karupayun added a commit to karupayun/triton that referenced this pull request Nov 23, 2023
@karupayun
Deduplicate llvm-hash value and move it under cmake folder
9b6f644 
In this PR we are deduplicating the llvm-hash value (currently it's
in the llvm-hash.txt file but also under python/setup.py. The new
location is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
triton-lang#2570.

Test: Pushed the same change to llvm-head branch. Trigger a
llvm-build. It passed.
@karupayun karupayun mentioned this pull request Nov 23, 2023
Merged
plotfi pushed a commit to plotfi/triton that referenced this pull request Nov 26, 2023
@karupayun
[BUILD] deduplicate llvm-hash value and move it under cmake folder (t…
c48384a 
…riton-lang#2698)

In this PR we are deduplicating the llvm-hash value (currently it's in
the llvm-hash.txt file but also under python/setup.py. The new location
is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
triton-lang#2570.

Test: Pushed the same change to llvm-head branch. Trigger a llvm-build
(https://github.com/openai/triton/actions/runs/6970868398), it passed.
feihugis pushed a commit to feihugis/triton that referenced this pull request Feb 13, 2024
@karupayun
[BUILD] deduplicate llvm-hash value and move it under cmake folder (t…
33881fd 
…riton-lang#2698)

In this PR we are deduplicating the llvm-hash value (currently it's in
the llvm-hash.txt file but also under python/setup.py. The new location
is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
triton-lang#2570.

Test: Pushed the same change to llvm-head branch. Trigger a llvm-build
(https://github.com/openai/triton/actions/runs/6970868398), it passed.
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
@gflegar @ashay @khasanovaa
[DEPS] bump LLVM version to llvm/llvm-project@49af650 (triton-lang#2570)
f73775f 
Co-authored-by: Ashay Rane <[email protected]>
Co-authored-by: khasanovaa <[email protected]>
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
@karupayun
[BUILD] deduplicate llvm-hash value and move it under cmake folder (t…
03e75dc 
…riton-lang#2698)

In this PR we are deduplicating the llvm-hash value (currently it's in
the llvm-hash.txt file but also under python/setup.py. The new location
is cmake/llvm-hash.txt.

Both changes were suggested by jlebar in
triton-lang#2570.

Test: Pushed the same change to llvm-head branch. Trigger a llvm-build
(https://github.com/openai/triton/actions/runs/6970868398), it passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebar jlebar jlebar approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gflegar @jlebar @ptillet @ashay @khasanovaa