Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust font colours and sizes to more closely reflect Arc #97

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Adjust font colours and sizes to more closely reflect Arc #97

merged 1 commit into from
Aug 25, 2016

Conversation

CDrummond
Copy link
Contributor

I've adjusted the ItemView header to remove the top and left borders. But the right border is also removed?

frame.top=0
frame.bottom=1
frame.left=0
frame.right=1

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

frame.left=1
frame.right=0

for header separators to be drawn because their width is that of left frame.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 25/08/16 18:31, tsujan wrote:

In Kvantum/themes/kvthemes/KvArc/KvArc.kvconfig
#97 (comment):

@@ -230,10 +230,10 @@ indicator.element=tree

[HeaderSection]
inherits=PanelButtonCommand
-frame.top=2
-frame.bottom=2
-frame.left=2
-frame.right=2
+frame.top=0
+frame.bottom=1
+frame.left=0
+frame.right=1

This should be

|frame.left=1 frame.right=0 |

for header separators to be drawn because their width is that of left
frame.

Hmm... Don't want line on the left - as it then creates a double line
with the itemview frame :-(

@tsujan
Copy link
Owner

tsujan commented Aug 25, 2016

Don't want line on the left - as it then creates a double line with the itemview frame

OK! The header separators can be added in another way too. I merge this; will fix the separators later.

@tsujan tsujan merged commit 94628aa into tsujan:master Aug 25, 2016
@CDrummond CDrummond deleted the arc_mods branch June 29, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants