Add support for sprockets-rails 3 and sprockets 4.
#965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sprockets-rails` 3 already precompiles any asset that is referenced by the `font-path` and `image-path` helpers, and `sprockets` 4 does not support Regexpes as the `precompile` flag.
glebm
added a commit
that referenced
this pull request
Sep 27, 2015
Add support for `sprockets-rails` 3 and `sprockets` 4.
Member
|
Thanks! |
|
I'm trying rails 5 and spent 2 hours to realize I need this fix, would be great if can release a new version to avoid other developer burning their time. |
Eric-Guo
added a commit
to cloud-mes/demo
that referenced
this pull request
Oct 6, 2015
bootstrap-sass need below patch. twbs/bootstrap-sass#965
Eric-Guo
added a commit
to cloud-mes/demo
that referenced
this pull request
Oct 7, 2015
bootstrap-sass need below patch. twbs/bootstrap-sass#965
Eric-Guo
added a commit
to cloud-mes/demo
that referenced
this pull request
Oct 8, 2015
bootstrap-sass need below patch. twbs/bootstrap-sass#965
Eric-Guo
added a commit
to cloud-mes/demo
that referenced
this pull request
Oct 9, 2015
bootstrap-sass need below patch. twbs/bootstrap-sass#965
Eric-Guo
added a commit
to cloud-mes/demo
that referenced
this pull request
Oct 10, 2015
bootstrap-sass need below patch. twbs/bootstrap-sass#965
Contributor
|
I believe the following may have introduced a breaking change: When running the tests for https://github.com/alphagov/govuk_admin_template, a gem and tested against a dummy Rails 3 app, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprockets-rails3 already precompiles any asset that is referenced by thefont-pathandimage-pathhelpers, andsprockets4 does not support Regexpes as theprecompileflag.