Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown — Add option to make the dropdown menu clickable #33389

Merged
merged 7 commits into from
Apr 20, 2021
Merged

Dropdown — Add option to make the dropdown menu clickable #33389

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41538d1
Add option to make the dropdown menu clickable
rohit2sharma95 Mar 17, 2021
0d916e1
Update dropdown.js
XhmikosR Mar 18, 2021
3e27fd7
Update and add tests for `autoClose` option
rohit2sharma95 Mar 23, 2021
ce84722
Update the documentation for `autoClose` option
rohit2sharma95 Apr 18, 2021
357ae2a
Merge branch 'main' into rohit/clickable-dropdown-menu
rohit2sharma95 Apr 19, 2021
6a56dbb
Update dropdowns.md
XhmikosR Apr 20, 2021
585c4b3
Merge branch 'main' into rohit/clickable-dropdown-menu
XhmikosR Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update dropdown.js
  • Loading branch information
@XhmikosR @rohit2sharma95
XhmikosR authored and rohit2sharma95 committed Apr 18, 2021
commit 0d916e119493d3777d7ea6fc721efdc18934ffeb
1 change: 0 additions & 1 deletion js/src/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ class Dropdown extends BaseComponent {
})
}

// eslint-disable-next-line complexity
static clearMenus(event) {
if (event) {
if (event.button === RIGHT_MOUSE_BUTTON || (event.type === 'keyup' && event.key !== TAB_KEY)) {
Expand Down