pulling changes from latest dtq release #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the getLangCodeIfCzech links * Changed the dropdown-menu and services links
* Creating docker-compose file useful for building clarin-dspace on MAC computers (cherry picked from commit 7de4761) * Add link to communities and collections on home page (cherry picked from commit 4673e39) --------- Co-authored-by: Milan Kuchtiak <[email protected]>
…pace#837) * Updated the no file preview message and refactored some code. * Added a non null check when accessing the object properties and the message is refactored.
There was a problem hiding this comment.
Pull Request Overview
This PR pulls in updates from the latest dtq release, including changes to deployment configuration, menu links, and improvements in the file preview components. Key changes include:
- Updates to URL generation in header templates and components for consistent absolute linking.
- Refactoring of file preview components to use safe navigation operators and pipeline operators.
- Adjustment of the deploy action path in the GitHub workflows.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/themes/dspace/app/header/header.component.html | Updated navigation links to use absolute paths. |
| src/app/item-page/simple/field-components/preview-section/preview-section.component.ts | Applied safe navigation operator for email configuration. |
| src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.ts | Introduced pipe with getFirstSucceededRemoteData and new helper method hasNoPreview(). |
| src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.html | Updated preview check to use hasNoPreview() helper. |
| src/app/home-page/home-page.component.html | Added new link in the advanced search section for global community browsing. |
| src/app/header/header.component.ts | Modified getLangCodeIfCzech behavior and adjusted translations mapping. |
| .github/disabled-workflows/deploy.yml | Changed deploy action reference to point to the workflow file. |
Files not reviewed (2)
- src/assets/i18n/cs.json5: Language not supported
- src/assets/i18n/en.json5: Language not supported
Comments suppressed due to low confidence (3)
src/themes/dspace/app/header/header.component.html:20
- [nitpick] The change from a relative URL ('services/catalog') to an absolute URL ('/services/catalog') could affect navigation in contexts where relative paths are expected. Please verify that this adjustment aligns with the intended routing configuration.
<a href="/https/github.com/services/catalog" class="lindat-nav-link">{{'navbar.community-list' | translate}}</a>
src/app/header/header.component.ts:53
- [nitpick] The updated getLangCodeIfCzech method now returns either 'cs' or an empty string, which simplifies the logic. Please ensure that downstream code consuming this value correctly handles the empty string scenario.
return this.localeService.getCurrentLanguageCode() === 'cs' ? 'cs' : '';
.github/disabled-workflows/deploy.yml:48
- [nitpick] The deploy workflow now references the workflow file path instead of a custom action; please confirm this change is intentional and that it triggers the intended deployment behavior.
uses: ./.github/workflows/deploy.yml
...-page/simple/field-components/preview-section/file-description/file-description.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the following changes: