Skip to content

fix(hr): Fix HR not working on iOS#22083

Merged
dr1rrb merged 2 commits into
masterfrom
dev/dr/hrLinker
Dec 11, 2025
Merged

fix(hr): Fix HR not working on iOS#22083
dr1rrb merged 2 commits into
masterfrom
dev/dr/hrLinker

Conversation

@dr1rrb

@dr1rrb dr1rrb commented Dec 10, 2025

Copy link
Copy Markdown
Member

linked #21857

🐞 Bugfix

Fix HR not working on iOS

What is the current behavior? 🤔

  • Trimmer/linker removes HR messages
  • Timmer/Linker remove unused types and properties that might be used later when using HR to update app

What is the new behavior? 🚀

Trimmer/linker disabled when RemoteControl package is referenced.

PR Checklist ✅

Other information ℹ️

There is still an issue where HR is not working with debugger attached with VSCode: https://github.com/unoplatform/uno.vscode/issues/1226

Copilot AI review requested due to automatic review settings December 10, 2025 15:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Hot Reload (HR) functionality on iOS by disabling the linker/trimmer when the RemoteControl package is referenced. The trimmer was removing HR messages and reflection metadata required for Hot Reload to function properly. The fix adds MSBuild logic to automatically set linker modes to 'None' for iOS and Android, with warning messages if developers manually override these settings.

Key Changes

  • Adds <Choose> block to automatically disable linking on iOS (MTouchLink=None) and Android (AndroidLinkMode=None) when not already set
  • Adds warning targets that alert developers if linking is manually enabled, as it breaks Hot Reload functionality
  • Both changes are conditionally applied only when targeting iOS or Android platforms

Comment thread src/Uno.UI.RemoteControl/buildTransitive/Uno.WinUI.DevServer.targets Outdated
Comment thread src/Uno.UI.RemoteControl/buildTransitive/Uno.WinUI.DevServer.targets Outdated
@unodevops

Copy link
Copy Markdown
Contributor

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 10, 2025 17:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@unodevops

Copy link
Copy Markdown
Contributor

@dr1rrb dr1rrb merged commit 3076228 into master Dec 11, 2025
74 checks passed
@dr1rrb dr1rrb deleted the dev/dr/hrLinker branch December 11, 2025 15:38
@agneszitte

Copy link
Copy Markdown
Member

@Mergifyio backport release/stable/6.4

@mergify

mergify Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

backport release/stable/6.4

✅ Backports have been created

Details

agneszitte added a commit that referenced this pull request Dec 17, 2025
…6.4/pr-22083

fix(hr): Fix HR not working on iOS (backport #22083)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants