Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DatePicker): set placeholder based on modelValue #1604

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(DatePicker): set placeholder based on modelValue #1604

merged 1 commit into from
Feb 4, 2025

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Feb 3, 2025

Closes #1591.

@epr3 epr3 requested a review from zernonia February 3, 2025 18:44
@epr3 epr3 self-assigned this Feb 3, 2025
@zernonia zernonia linked an issue Feb 4, 2025 that may be closed by this pull request
[Bug]: DatePicker with granularity other than day is buggy #1591
Closed
zernonia
zernonia approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epr3 ! Seems to be working fine now 😁

@zernonia zernonia merged commit 293798a into main Feb 4, 2025
3 checks passed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/radix-vue@1604

commit: 5244887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees

@epr3 epr3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DatePicker with granularity other than day is buggy
2 participants
@epr3 @zernonia