Adds a protected flag to Roles. #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds immutable protected field to the Role entity - Modifies Role Authorizer to remove "delete" from allowed_privileges for protected roles - Adds tests for protected roles
Contributor
Author
|
@jasonmule When you get a chance, can you please do a code review of this pull request? Thanks! |
| SET protected = 1 | ||
| WHERE | ||
| name = 'user' OR name = 'admin' | ||
| "); |
Contributor
There was a problem hiding this comment.
Could this migration reinstate the user and admin roles if they don't exist too?
Contributor
Author
There was a problem hiding this comment.
Makes sense. I'll get that in today.
Contributor
|
This looks really good. Happy to land. |
…migration for protected roles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test these changes by:
Fixes #1017, #1018, #1206 .
Ping @ushahidi/platform
This change is