Refactor save-to-file to be more generic#658
Merged
thegrims merged 1 commit intoustaxes:masterfrom Oct 20, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change save to file to be more generic. Dispatch actions to load and save entire redux state. Uses a separate middleware reducer to handle special actions for saving and resetting state. This is part of the effort to replace #566.
This probably exists as a package already, but in its present state this could be easily exported as separate npm package.
I tried for a while to make reasonable tests for the save and upload buttons, but didn't make much progress. I'm suggesting we press forward merging this and then make an issue for testing it.
What kind of change does this PR introduce? (delete not applicable)