Skip to content

Conversation

@bruceg
Copy link
Member

@bruceg bruceg commented Jan 14, 2026

Summary

With the introduction of internal timing measurements in seconds as histograms, the lower bound of 2^-6 (~15ms) in the internal histogram storage is no longer precise enough to properly capture the required measurements. This change extends the smallest bucket down to 2^-12 (~244us), which is the inverse of the largest bucket of 2^12 (4096).

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance
  • Enhancement

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@bruceg bruceg requested a review from a team as a code owner January 14, 2026 19:57
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector domain: metrics Anything related to Vector's metrics events source: internal_metrics Anything `internal_metrics` source related labels Jan 14, 2026
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Jan 14, 2026
With the introduction of internal timing measurements in seconds as histograms,
the lower bound of 2^-6 (~15ms) in the internal histogram storage is no longer
precise enough to properly capture the required measurements. This change
extends the smallest bucket down to 2^-12 (~244us), which is the inverse of the
largest bucket of 2^12 (4096).
@bruceg bruceg force-pushed the bruceg/expand-histogram-storage branch from a6b5d84 to 0f75f5a Compare January 15, 2026 16:38
@bruceg bruceg changed the title enhancement(observability): Expand internal histogram precision enhancement(observability)!: Expand internal histogram precision Jan 15, 2026
@bruceg bruceg added the meta: breaking change Anything that breaks backward compatibility. label Jan 15, 2026
@bruceg bruceg added this pull request to the merge queue Jan 15, 2026
Merged via the queue into master with commit 65afcd2 Jan 15, 2026
75 checks passed
@bruceg bruceg deleted the bruceg/expand-histogram-storage branch January 15, 2026 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: metrics Anything related to Vector's metrics events domain: observability Anything related to monitoring/observing Vector domain: sources Anything related to the Vector's sources meta: breaking change Anything that breaks backward compatibility. source: internal_metrics Anything `internal_metrics` source related type: enhancement A value-adding code change that enhances its existing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants