Skip to content

Conversation

@Munawwar
Copy link
Contributor

@Munawwar Munawwar commented Mar 3, 2022

Made SSG and SSR code similar. Comments and variable renames on store.js

Checklist:

Documentation / Examples

  • [✓] Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Mar 3, 2022
@Munawwar
Copy link
Contributor Author

Munawwar commented Mar 8, 2022

@leerob Requesting to merge PR. I wrote the initial example some months ago. This PR is just cleanup + comments.

@Munawwar
Copy link
Contributor Author

Munawwar commented Mar 8, 2022

rebased branch

@Munawwar
Copy link
Contributor Author

^ last force push was just rebasing branch again.

@ijjk ijjk requested a review from balazsorban44 as a code owner May 22, 2022 04:50
@kodiakhq kodiakhq bot merged commit bb7b758 into vercel:canary May 22, 2022
@premier213
Copy link

premier213 commented Jun 21, 2022

how to add multi-state to this example?
store = store ?? initializeStore(serverInitialState)

a new better solution is this:
const store = useMemo(() => initializeStore(state), [state])

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants