Skip to content

Convert amp-story example to TypeScript #38038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Jun 27, 2022
Merged

Convert amp-story example to TypeScript #38038

kodiakhq merged 2 commits into from
Jun 27, 2022

Conversation

@maxproske
Copy link
Contributor

@maxproske maxproske commented Jun 26, 2022

Converted AMP Story example over to TypeScript to align with the Examples guide.

Note: Requires v12.1.7-canary.41 or newer to build #37744 (comment)

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 26, 2022
ijjk
ijjk approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 1d5dd1b into vercel:canary Jun 27, 2022
@maxproske
Copy link
Contributor Author

maxproske commented Jun 27, 2022

Thanks JJ! I'm always amazed how quickly and how much you review.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxproske @ijjk