-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
refactor!: remove exporting internal APIs #14583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The reason was because |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
sapphi-red
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It would be nice to add this to https://github.com/vitejs/vite/blob/main/docs/guide/migration.md#advanced.
Description
config.ts:isDepsOptimizerEnabledandgetDepOptimizationConfigconfig.tsResolveWorkerOptionstoResolvedWorkerOptions(it was bugging me)./optimizerNOTE:
The removed internal typeused by vitestDepOptimizationOptionsis only referenced viaDepOptimizationOptions(exported), but I don't think it needs to also be exported.DepsOptimizeris only referenced atvite/packages/vite/src/node/plugins/resolve.ts
Line 118 in 62ae743
Also it's odd that we export
InternalResolveOptionsand most props there are actually internal too.Additional context
What is the purpose of this pull request?