Update CICD flows to enable automated releases and match the feature set laid out in #56#125
Merged
Update CICD flows to enable automated releases and match the feature set laid out in #56#125
Conversation
|
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various CI/CD workflows to support automated releases and aligns the build process with the feature set outlined in #56. Key changes include:
- Modifications in build properties handling in utils/inject_build_props.py.
- Refinements to the scheduler processing logic.
- Updates to multiple GitHub workflow files for release, nightly, release candidate, main, and development pipelines.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/inject_build_props.py | Modified build property construction to return a constant project name. |
| src/guidellm/scheduler/worker.py | Simplified error message formatting in async worker. |
| src/guidellm/scheduler/scheduler.py | Reformatted the computation of request limits for process scheduling. |
| .github/workflows/release.yml | Changed trigger from branch pushes to version tags and updated test commands. |
| .github/workflows/release-candidate.yml | Added new workflow for release candidates with corresponding build steps. |
| .github/workflows/nightly.yml | Adjusted Python version matrices and updated test commands and artifact steps. |
| .github/workflows/main.yml | Introduced a comprehensive main workflow for quality, type, and unit tests. |
| .github/workflows/development.yml | Expanded development workflow with additional build and artifact steps. |
Files not reviewed (1)
- .github/workflows/quality.yml: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:67
- Removal of coverage reporting flags may reduce visibility into test coverage; consider reintroducing them if coverage metrics are required by your quality standards.
run: tox -e test-unit
utils/inject_build_props.py:38
- All build types now return a constant project name 'guidellm'; please verify that this change is intentional and aligns with the requirements in #56, especially for 'dev' and 'nightly' builds.
return "guidellm", version
.github/workflows/nightly.yml:22
- The extra '-m' flag may be unintended and could affect test marker filtering; please verify if this flag is necessary.
run: tox -e test-unit -- -m --cov=guidellm --cov-report=term-missing --cov-fail-under=75
sjmonson
reviewed
Apr 18, 2025
Co-authored-by: Samuel Monson <smonson@redhat.com>
sjmonson
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56 and should enable 0.2.0 release plus automated releases going forward