Support dashed arguments for benchmark args#441
Merged
Conversation
1d547d0 to
5a7aa82
Compare
Signed-off-by: Samuel Monson <smonson@redhat.com>
5a7aa82 to
a9f98f3
Compare
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
47385ec to
84538d9
Compare
jaredoconnell
approved these changes
Oct 31, 2025
Collaborator
jaredoconnell
left a comment
There was a problem hiding this comment.
This seems fine. This may cause some fragmentation in usage, but this doesn't seem like something that would be a maintenance burden.
markurtz
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For all arguments in
BenchmarkGenerativeTextArgssupport dashed versions of the name during validation to match the CLI. Additionally alias the argumentdata_request_formattertorequest_type.Details
Alias are configured so that if both options are specified, the original name takes precedence. E.g. the order of precedence is
max_seconds > max-seconds.ForChanged this because it caused precedence issues with CLI arg. Order is nowdata_request_formatterthe request type alias takes precedence. E.g.request_type > request-type > data_request_formatter.data_request_formatter > data-request-formatter > request_type > request-type.Test Plan
The following scenario file can be used to test. Modify which fields are uncommented to test precedence.
Related Issues
Use of AI
## WRITTEN BY AI ##)