Skip to content

Support dashed arguments for benchmark args#441

Merged
sjmonson merged 3 commits intomainfrom
feat/args_alias
Oct 31, 2025
Merged

Support dashed arguments for benchmark args#441
sjmonson merged 3 commits intomainfrom
feat/args_alias

Conversation

@sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Oct 30, 2025

Summary

For all arguments in BenchmarkGenerativeTextArgs support dashed versions of the name during validation to match the CLI. Additionally alias the argument data_request_formatter to request_type.

Details

Alias are configured so that if both options are specified, the original name takes precedence. E.g. the order of precedence is max_seconds > max-seconds.

For data_request_formatter the request type alias takes precedence. E.g. request_type > request-type > data_request_formatter. Changed this because it caused precedence issues with CLI arg. Order is now data_request_formatter > data-request-formatter > request_type > request-type.

Test Plan

The following scenario file can be used to test. Modify which fields are uncommented to test precedence.

target: <hostname>
#request_type: text_completions
#request-type: text_completions
data_request_formatter: text_completions
profile: concurrent
rate: 2
max_seconds: 30
data:
  prompt_tokens: 256
  output_tokens: 128

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
@sjmonson sjmonson marked this pull request as ready for review October 31, 2025 15:59
Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. This may cause some fragmentation in usage, but this doesn't seem like something that would be a maintenance burden.

@sjmonson sjmonson merged commit 7b07866 into main Oct 31, 2025
12 of 17 checks passed
@sjmonson sjmonson deleted the feat/args_alias branch October 31, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants